feat: add tiles view for shared with me view #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
force-pushed
the
issues/1338
branch
from
12d0bd8 to
a6d0754
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tiles view support for the "Shared with Me" view in the files application. The changes enable users to switch between table and tiles view modes when viewing shares that have been shared with them.
Key changes:
- Added tiles view extension support for the "Shared with Me" view
- Moved sync and role indicators from table columns to status indicators system
- Updated test selectors to support both table and tiles view modes
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/web-app-files/src/views/shares/SharedWithMe.vue | Added view mode support and folder view functionality |
| packages/web-app-files/src/components/Shares/SharedWithMeSection.vue | Refactored to use dynamic component rendering and removed sync column |
| packages/web-pkg/src/helpers/statusIndicators.ts | Added sync and role indicators for incoming shares |
| packages/web-pkg/src/components/FilesList/ResourceTable.vue | Removed syncEnabled column slot and related CSS |
| packages/web-app-files/src/extensionPoints.ts | Added shared-with-me extension point and renamed others for consistency |
| packages/web-client/src/helpers/share/types.ts | Updated shareRoles type from UnifiedRoleDefinition to ShareRole |
| tests/e2e/support/objects/app-files/share/actions.ts | Updated selector to support both table and tiles view |
| tests/e2e/cucumber/features/user-settings/profilePhoto.feature | Added table view switch step for test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@kulmann @JammingBen I don't like the variable naming in the statusIndicators, I added as well as the type name I gave them, maybe you have some better ideas |
AlexAndBear
force-pushed
the
issues/1338
branch
from
392450a to
dd17769
Compare
Contributor
|
#1360 The fix will be in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Types of changes