fix: rounded bottom corner on tile preview hover #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
fix/tiles-preview-rounded-corners
branch
from
2cf1490 to
7e3c98d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with rounded bottom corners not appearing correctly on tile preview hover in the FilesList component. The fix moves the hover styling from Tailwind utility classes to a custom CSS rule to address compatibility issues.
- Removed hover-based Tailwind class that wasn't working properly
- Added custom CSS with
@layer utilitiesto handle hover styling for tile previews - Applied consistent rounded corner styling to project thumbnails
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-pkg/src/components/FilesList/ResourceTile.vue | Replaced problematic Tailwind hover class with custom CSS rule and added utilities layer styling |
| packages/web-app-files/src/views/spaces/Projects.vue | Added conditional rounded corner styling for selected resources |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work with Tailwind utility classes on the element itself, for some reason... 🤷
fixes #1278