feat: show disabled delete button for locked files #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to show a disabled delete button with a tooltip for locked files instead of hiding the button entirely. The change improves user experience by providing visual feedback and explanation when files cannot be deleted due to being locked.
Key changes:
- Moved locked file check from
isVisibletoisDisabledproperty - Added tooltip explaining why locked files can't be deleted
- Updated tests to cover the new disabled state behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| useFileActionsDelete.ts | Implements disabled state for locked files with explanatory tooltip |
| useFileActionsDelete.spec.ts | Adds comprehensive test coverage for the new disabled state functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
And adds a tooltip explaining why the file can't be deleted. This is helpful when opening a file with Collabora.
JammingBen
force-pushed
the
feat/delete-locked-file-tooltip
branch
from
8c7684c to
e29315a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And adds a tooltip explaining why the file can't be deleted. This is helpful when opening a file with Collabora.
closes opencloud-eu/opencloud#1195