fix: reloading settings on public link page #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where reloading the settings page from a public link context was broken. The key change is passing contextRouteName: 'files-public-link' to the settings URL when accessed from a public link page.
- Refactored UserMenu component from Options API to Composition API (script setup)
- Added logic to conditionally include
contextRouteNamequery parameter for public link contexts - Added test coverage for account settings route behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| UserMenu.vue | Refactored to Composition API, added conditional contextRouteName query param for public link contexts, and simplified user/quota checks |
| UserMenu.spec.ts | Added new test suite for account settings route behavior and updated mock data to include auth state |
| UserMenu.spec.ts.snap | Updated snapshot to reflect component prop changes from refactoring |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
fix/reloading-settings-on-public
branch
from
b06651f to
4aaa36d
Compare
JammingBen
force-pushed
the
fix/reloading-settings-on-public
branch
from
4aaa36d to
ebab193
Compare
AlexAndBear
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant change for the bug fix is passing
contextRouteName: 'files-public-link'to the settings url.fixes #1380