Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

…er than 120

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copilot AI review requested due to automatic review settings October 24, 2025 08:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where links in the markdown editor were being shortened regardless of their length. The change ensures that only links longer than 120 characters are shortened.

Key Changes:

  • Added codeMirrorExtensions method to configure link shortener behavior
  • Set maxLength to 120 characters for the link shortener extension

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Oct 24, 2025

Hm I think we should only enable the link shortener when working with markdown files 🤔

Edit: done ✅

@AlexAndBear AlexAndBear requested a review from kulmann October 24, 2025 17:21
'htmlPreview',
'pageFullscreen'
]"
:read-only="isReadOnly"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not neccessary

@AlexAndBear AlexAndBear merged commit 40d6741 into main Oct 27, 2025
28 checks passed
@AlexAndBear AlexAndBear deleted the issues/1410 branch October 27, 2025 07:56
@openclouders openclouders mentioned this pull request Oct 27, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pasting URLs always causes them to be shortened.

3 participants