Skip to content

fix: add wait for upload input before setInputFiles #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScharfViktor merged 1 commit into from
Oct 24, 2025
Merged

fix: add wait for upload input before setInputFiles #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"test:e2e:cucumber:webkit": "BROWSER=webkit NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e --parallel ${PARALLEL:-1}",
"test:e2e:mobile-parallel": "bash -c 'FORCE_COLOR=1 pnpm run test:e2e:mobile-chromium > mobile-chromium.log 2>&1 & pid1=$!; FORCE_COLOR=1 pnpm run test:e2e:mobile-webkit > mobile-webkit.log 2>&1 & pid2=$!; FORCE_COLOR=1 pnpm run test:e2e:ipad-chromium > ipad-chromium.log 2>&1 & pid3=$!; FORCE_COLOR=1 pnpm run test:e2e:ipad-safari > ipad-safari.log 2>&1 & pid4=$!; wait $pid1; ec1=$?; wait $pid2; ec2=$?; wait $pid3; ec3=$?; wait $pid4; ec4=$?; echo \"=== LOG FILES ===\"; for log in *.log; do echo \"--- $log ---\"; cat $log; echo; done; echo \"=== RESULTS ===\"; echo \"Mobile Chromium: $([ $ec1 -eq 0 ] && echo ✅ PASSED || echo ❌ FAILED)\"; echo \"Mobile WebKit: $([ $ec2 -eq 0 ] && echo ✅ PASSED || echo ❌ FAILED)\"; echo \"iPad Chromium: $([ $ec3 -eq 0 ] && echo ✅ PASSED || echo ❌ FAILED)\"; echo \"iPad Safari: $([ $ec4 -eq 0 ] && echo ✅ PASSED || echo ❌ FAILED)\"; if [ $ec1 -ne 0 ] || [ $ec2 -ne 0 ] || [ $ec3 -ne 0 ] || [ $ec4 -ne 0 ]; then exit 1; fi'",
"test:e2e:mobile-chromium": "BROWSER=mobile-chromium NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e ./tests/e2e/cucumber/features/mobile-view",
"test:e2e:mobile-webkit": "BROWSER=mobile-webkit NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e ./tests/e2e/cucumber/features/mobile-view",
"test:e2e:mobile-webkit": "FAIL_ON_UNCAUGHT_CONSOLE_ERR=false BROWSER=mobile-webkit NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e ./tests/e2e/cucumber/features/mobile-view",
"test:e2e:ipad-chromium": "BROWSER=ipad-chromium NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e ./tests/e2e/cucumber/features/mobile-view",
"test:e2e:ipad-safari": "BROWSER=ipad-landscape-webkit NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e ./tests/e2e/cucumber/features/mobile-view",
"test:unit": "NODE_OPTIONS=--unhandled-rejections=throw vitest --config ./tests/unit/config/vitest.config.ts",
Expand Down
5 changes: 4 additions & 1 deletion tests/e2e/support/objects/app-files/resource/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,11 @@ const performUpload = async (args: uploadResourceArgs): Promise<void> => {
}

await page.locator(resourceUploadButton).click()
const inputSelector = type === 'folder' ? folderUploadInput : fileUploadInput
await page.locator(inputSelector).waitFor({ state: 'visible' })

let uploadAction: Promise<void> = page
.locator(type === 'folder' ? folderUploadInput : fileUploadInput)
.locator(inputSelector)
.setInputFiles(resources.map((file) => file.path))

if (option) {
Expand Down