fix: hide save buttons in topbar for read-only files #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where save buttons were incorrectly displayed in the top bar for read-only files. The fix introduces an isReadOnly prop that is used to conditionally hide the autosave indicator and save action buttons when files are not writable. Additionally, the PR refactors the AppWrapper component from options API to script setup syntax and replaces brittle snapshot tests with more maintainable element-based assertions.
Key changes:
- Added
isReadOnlyprop toAppTopBarcomponent to conditionally render save-related UI elements - Refactored
AppWrapper.vuefrom options API to script setup syntax - Replaced snapshot tests with explicit element existence checks in
AppTopBar.spec.ts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web-pkg/tests/unit/components/snapshots/AppTopBar.spec.ts.snap | Removed all snapshot test baselines as they were replaced with element checks |
| packages/web-pkg/tests/unit/components/AppTopBar.spec.ts | Updated tests to use element existence checks instead of snapshots and added test for autosave indicator visibility |
| packages/web-pkg/src/components/AppTopBar.vue | Added isReadOnly prop and conditional rendering logic for autosave indicator |
| packages/web-pkg/src/components/AppTemplates/AppWrapper.vue | Refactored from options API to script setup and integrated isReadOnly prop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also replaced the snapshot tests with proper element checks because they were once again broken without anybody noticing.
Also the refactors the
AppWrappercomponent to script setup.fixes #1434