fix: remove horizontal scrollbar when opening upload menu #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scrollbar became visible because of the hidden input element. It just needs a hidden overflow on the parent container.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ResourceUpload component from Vue 2 Options API to Vue 3 Composition API with <script setup> syntax. The main changes streamline the component code and add CSS classes for proper positioning of the hidden file input element.
- Converts from Options API (
defineComponent) to Composition API (<script setup>) - Adds
relative overflow-hiddenclasses to the wrapper div for proper layout - Simplifies import statements and removes unnecessary destructuring
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-app-files/src/components/AppBar/Upload/ResourceUpload.vue | Refactored from Options API to Composition API with <script setup>, added CSS classes to wrapper div for proper positioning |
| packages/web-app-files/tests/unit/components/AppBar/Upload/snapshots/ResourceUpload.spec.ts.snap | Updated snapshot to reflect new CSS classes added to the wrapper div |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexAndBear
approved these changes
Nov 7, 2025
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
openclouders
pushed a commit
that referenced
this pull request
Nov 7, 2025
…-scrollbar fix: remove horizontal scrollbar when opening upload menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrollbar became visible because of the hidden input element. It just needs a hidden overflow on the parent container.
fixes #1543