enforce password for writable public links #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScharfViktor
requested review from
JammingBen,
Copilot and
saw-jan
and removed request for
JammingBen and
Copilot
ScharfViktor
force-pushed
the
enforce-password-writable-public-links
branch
from
54d09dc to
bbae8c7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces password requirements for writable public links by adding functionality to validate that passwords are set when changing link roles to write-enabled permissions.
- Adds
deletePasswordmethod to remove passwords from existing public links - Adds
requirePasswordparameter to thechangeRolefunction to trigger password generation when changing to writable roles - Adds e2e test scenario validating password enforcement when switching from view-only to writable public link roles
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/link/index.ts | Exports new deletePassword method for Link class |
| tests/e2e/support/objects/app-files/link/actions.ts | Implements password deletion and adds password requirement logic to role changes |
| tests/e2e/cucumber/steps/ui/links.ts | Adds step definitions for password-protected role changes and password deletion |
| tests/e2e/cucumber/features/shares/link.feature | Adds test scenario verifying password enforcement for writable public links |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
approved these changes
Dec 19, 2025
Contributor
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
Code LGTM, formatter complains though.
ScharfViktor
force-pushed
the
enforce-password-writable-public-links
branch
from
bbae8c7 to
e06b855
Compare
openclouders
pushed a commit
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related opencloud-eu/opencloud#2048