-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add required mark to input fields that require a value to be set #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a visual “required” asterisk indicator to all form inputs that must be filled, by introducing and propagating a required-mark prop on design-system components and updating snapshots/test stubs accordingly.
- Exposed
requiredMark/inputRequiredMarkboolean props inOcSelectandOcModal - Updated various modals, dropdowns, and sidebars to pass
required-markinstead of hard-coding “*” - Bumped snapshots to include the new
requiredmark/required-markattributes
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/src/components/Modals/DatePickerModal.vue | Added required-mark on date-picker component |
| packages/web-pkg/src/components/CreateShortcutModal.vue | Manually added <span>*</span> for required labels |
| packages/web-pkg/src/components/CreateLinkModal.vue | Switched label logic to use required-mark on password input |
| packages/web-pkg/src/components/AppBar/CreateSpace.vue | Enabled inputRequiredMark for the space name prompt |
| packages/web-app-files/src/components/SideBar/Shares/Links/EditDropdown.vue | Added inputRequiredMark + inline validation |
| packages/web-app-files/src/components/Modals/SetLinkPasswordModal.vue | Added required-mark on password challenge input |
| packages/web-app-admin-settings/tests/unit/components/Users/snapshots/LoginModal.spec.ts.snap | Updated snapshot to include requiredmark="true" |
| packages/web-app-admin-settings/tests/unit/components/Users/snapshots/GroupSelect.spec.ts.snap | Updated snapshot to include requiredmark attr |
| packages/web-app-admin-settings/tests/unit/components/Users/SideBar/snapshots/EditPanel.spec.ts.snap | Updated stubs to show requiredmark="true" on text inputs |
| packages/web-app-admin-settings/tests/unit/components/Groups/SideBar/snapshots/EditPanel.spec.ts.snap | Updated group edit snapshot to include required-mark |
| packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue | Added required-mark to all user edit form inputs |
| packages/web-app-admin-settings/src/components/Users/RemoveFromGroupsModal.vue | Added required-mark on multi-select for group removal |
| packages/web-app-admin-settings/src/components/Users/LoginModal.vue | Added required-mark to login status select input |
| packages/web-app-admin-settings/src/components/Users/GroupSelect.vue | Exposed requiredMark prop and added required-mark attr |
| packages/web-app-admin-settings/src/components/Users/CreateUserModal.vue | Replaced inline “*” with required-mark on text inputs |
| packages/web-app-admin-settings/src/components/Users/AddToGroupsModal.vue | Added required-mark on multi-select for adding groups |
| packages/web-app-admin-settings/src/components/Groups/SideBar/EditPanel.vue | Added required-mark to group edit text input |
| packages/web-app-admin-settings/src/components/Groups/CreateGroupModal.vue | Replaced inline “*” with required-mark on group name input |
| packages/design-system/src/components/OcSelect/OcSelect.vue | Added requiredMark prop and * in the label template |
| packages/design-system/src/components/OcModal/OcModal.vue | Added inputRequiredMark prop for modal input fields |
packages/web-app-admin-settings/src/components/Users/GroupSelect.vue
Outdated
Show resolved
Hide resolved
…ct.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Related Issue
How Has This Been Tested?
Types of changes