Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a visual “required” asterisk indicator to all form inputs that must be filled, by introducing and propagating a required-mark prop on design-system components and updating snapshots/test stubs accordingly.

  • Exposed requiredMark/inputRequiredMark boolean props in OcSelect and OcModal
  • Updated various modals, dropdowns, and sidebars to pass required-mark instead of hard-coding “*”
  • Bumped snapshots to include the new requiredmark/required-mark attributes

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/web-pkg/src/components/Modals/DatePickerModal.vue Added required-mark on date-picker component
packages/web-pkg/src/components/CreateShortcutModal.vue Manually added <span>*</span> for required labels
packages/web-pkg/src/components/CreateLinkModal.vue Switched label logic to use required-mark on password input
packages/web-pkg/src/components/AppBar/CreateSpace.vue Enabled inputRequiredMark for the space name prompt
packages/web-app-files/src/components/SideBar/Shares/Links/EditDropdown.vue Added inputRequiredMark + inline validation
packages/web-app-files/src/components/Modals/SetLinkPasswordModal.vue Added required-mark on password challenge input
packages/web-app-admin-settings/tests/unit/components/Users/snapshots/LoginModal.spec.ts.snap Updated snapshot to include requiredmark="true"
packages/web-app-admin-settings/tests/unit/components/Users/snapshots/GroupSelect.spec.ts.snap Updated snapshot to include requiredmark attr
packages/web-app-admin-settings/tests/unit/components/Users/SideBar/snapshots/EditPanel.spec.ts.snap Updated stubs to show requiredmark="true" on text inputs
packages/web-app-admin-settings/tests/unit/components/Groups/SideBar/snapshots/EditPanel.spec.ts.snap Updated group edit snapshot to include required-mark
packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue Added required-mark to all user edit form inputs
packages/web-app-admin-settings/src/components/Users/RemoveFromGroupsModal.vue Added required-mark on multi-select for group removal
packages/web-app-admin-settings/src/components/Users/LoginModal.vue Added required-mark to login status select input
packages/web-app-admin-settings/src/components/Users/GroupSelect.vue Exposed requiredMark prop and added required-mark attr
packages/web-app-admin-settings/src/components/Users/CreateUserModal.vue Replaced inline “*” with required-mark on text inputs
packages/web-app-admin-settings/src/components/Users/AddToGroupsModal.vue Added required-mark on multi-select for adding groups
packages/web-app-admin-settings/src/components/Groups/SideBar/EditPanel.vue Added required-mark to group edit text input
packages/web-app-admin-settings/src/components/Groups/CreateGroupModal.vue Replaced inline “*” with required-mark on group name input
packages/design-system/src/components/OcSelect/OcSelect.vue Added requiredMark prop and * in the label template
packages/design-system/src/components/OcModal/OcModal.vue Added inputRequiredMark prop for modal input fields

AlexAndBear and others added 3 commits June 5, 2025 22:15
…ct.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AlexAndBear AlexAndBear requested a review from JammingBen June 10, 2025 13:06
@AlexAndBear AlexAndBear merged commit 3f31f20 into main Jun 10, 2025
18 checks passed
@AlexAndBear AlexAndBear deleted the issues/791 branch June 10, 2025 14:01
@openclouders openclouders mentioned this pull request Jun 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Required mark" for form fields

3 participants