fix: upload space image broken #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the broken upload of space images by ensuring the file input is properly reset after an upload event.
- Replaces resetting of the unwrapped ref value with a direct reset of the input element via event.currentTarget, ensuring that subsequent uploads work as expected.
- Aims to address broken behavior observed in the image upload functionality.
| const showModalImageSpace = (event: InputEvent) => { | ||
| const file = (event.currentTarget as HTMLInputElement).files[0] | ||
| unref(spaceImageInput).value = '' | ||
| ;(event.currentTarget as HTMLInputElement).value = '' |
There was a problem hiding this comment.
[nitpick] Instead of adding a semicolon before the assignment as a workaround for auto semicolon insertion, consider reviewing the surrounding code style to maintain consistency across the codebase. If the unref(spaceImageInput) reference is no longer used elsewhere, consider safely removing it to avoid redundancy.
Suggested change
| ;(event.currentTarget as HTMLInputElement).value = '' | |
| (event.currentTarget as HTMLInputElement).value = '' |
kulmann
approved these changes
Jun 26, 2025
Contributor
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
Thanks for the emergency fix 🚨 ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes