-
Notifications
You must be signed in to change notification settings - Fork 25
update keycloak tests #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the end-to-end Keycloak test suite by removing the old “provision” API layer, introducing keycloakUuid on entities, and adding full group support and matching Cucumber steps.
- Add
keycloakUuidto user and group types for tracking Keycloak IDs - Remove deprecated provision store and API, refactor to use
api.graphand directapi.keycloakcalls - Introduce Keycloak group creation, assignment, and cleanup flows in tests and feature files
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/support/types.ts | Added optional keycloakUuid field to User and Group. |
| tests/e2e/support/store/keycloak.ts | Dropped old user/group stores, now only tracks realm roles. |
| tests/e2e/support/environment/userManagement.ts | Simplified group lookup and removed Keycloak user helpers. |
| tests/e2e/support/api/keycloak/user.ts | Refactored user creation to use getAdminUser, dropped admin param. |
| tests/e2e/support/api/keycloak/group.ts | New Keycloak group API calls: create, add user, delete group. |
| tests/e2e/cucumber/steps/api.ts | Updated steps to call api.graph or api.keycloak, added group steps. |
| tests/e2e/cucumber/features/keycloak/smoke.feature | Added smoke tests covering Keycloak users and groups. |
Comments suppressed due to low confidence (1)
tests/e2e/support/api/keycloak/group.ts:75
- This error message is used in
deleteGroupand is misleading. Update it to something like'Failed while deleting group'.
checkResponseStatus(response, 'Failed while adding an user to the group')
e99cfe4 to
bf29f35
Compare
bf29f35 to
4bd0f45
Compare
Added:
creating group
adding group role
adding user to group
delete group
provision stepswhich API to use (Graph or Keycloak) have been removed.Now we explicitly specify this in the step definition.