Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jul 8, 2025

tests for:

  • setting space image/icon using context menu
  • deleting space image using context menu

Copilot AI review requested due to automatic review settings July 8, 2025 11:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the E2E test framework to support using the context menu for modifying space attributes (name, subtitle, description, quota, image) and adds icon setting/deletion flows.

  • Updated page‐object methods (Spaces) to accept a contextMenu flag and pass it through.
  • Updated action functions to branch between panel vs. context‐menu flows and added changeSpaceIcon/deleteSpaceImage.
  • Updated Cucumber step definitions and feature scenarios for context‐menu use and icon/image deletion.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
tests/e2e/support/objects/app-files/spaces/index.ts Added contextMenu parameter to space‐modification methods.
tests/e2e/support/objects/app-files/spaces/actions.ts Branched actions on contextMenu, added icon & delete‐image logic.
tests/e2e/cucumber/steps/ui/spaces.ts New step definitions for context‐menu and icon/image deletion.
tests/e2e/cucumber/features/spaces/project.feature Updated scenarios to invoke context‐menu flows and icon steps.
Comments suppressed due to low confidence (2)

tests/e2e/cucumber/features/spaces/project.feature:41

  • [nitpick] After deleting the space image, consider adding an assertion step to verify the image has been removed and the UI reflects the change.
    And "Alice" deletes the space "team.1" image

tests/e2e/cucumber/features/spaces/project.feature:42

  • [nitpick] Following the icon change step, add an assertion to confirm the new icon is displayed correctly in the UI for full end-to-end validation.
    And "Alice" changes the space "team.1" icon to "😍"

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm 🚀

@ScharfViktor ScharfViktor merged commit 740c41a into main Jul 10, 2025
23 checks passed
@ScharfViktor ScharfViktor deleted the setImageviaContextMenu branch July 10, 2025 10:31
@openclouders openclouders mentioned this pull request Jul 10, 2025
1 task
@openclouders openclouders mentioned this pull request Jul 21, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants