change browser in the script #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScharfViktor
requested review from
Copilot,
individual-it and
prashant-gurung899
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the E2E test configuration to use Playwright's bundled Chromium browser instead of system-installed Chrome. This change ensures consistent browser versions and avoids potential compatibility issues between Playwright and outdated system Chrome installations.
- Replace "chrome" references with "chromium" in CLI help text and error messages
- Update default browser configuration from "chrome" to "chromium"
- Modify npm script to use BROWSER=chromium environment variable
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/run-e2e.sh | Updates CLI help text, browser validation, and error messages to use "chromium" instead of "chrome" |
| tests/e2e/config.js | Changes default browser configuration from "chrome" to "chromium" |
| package.json | Updates test script environment variable to use BROWSER=chromium |
ScharfViktor
force-pushed
the
changeBrowserInScript
branch
from
6766949 to
eacd3e3
Compare
individual-it
approved these changes
Jul 24, 2025
ScharfViktor
force-pushed
the
changeBrowserInScript
branch
from
eacd3e3 to
84f517c
Compare
prashant-gurung899
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests with Playwright's bundled Chromium instead of the system-installed (and potentially outdated) Chrome.
We already have a mechanism in place that updates Playwright along with its compatible Chromium version, ensuring consistency and avoiding version mismatches.