gNMI server: add timeout config option #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gNMIc's gNMI server has a hardcoded 2min timeout on unary requests. While this value is fine for most cases it causes issues in our shop for long-ish cli origin requests. This change makes this timeout configurable via gnmi-server.timeout in the config. The default value remains 2min, behavior is kept unchanged unless gnmi-server.timeout is explicitly set.
ShimmerGlass
force-pushed
the
grpc-server-timeout
branch
from
8e750bd to
6fcd11d
Compare
Contributor
Author
|
Hello! did you have time to take a look at this small change ? :) |
Contributor
Author
|
Hello, any news ? :) |
Contributor
Author
|
@karimra ? |
karimra
approved these changes
Aug 18, 2025
Collaborator
|
Thanks for the contribution and sorry for the delay. I'm slowly emerging from a long leave. |
Contributor
Author
|
no problem and thank you for the review :) |
Contributor
Author
|
@karimra is there a release planned soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gNMIc's gNMI server has a hardcoded 2min timeout on unary requests. While this value is fine for most cases it causes issues in our shop for long-ish cli origin requests.
This change makes this timeout configurable via
gnmi-server.timeoutin the config. The default value remains 2min, behavior is kept unchanged unlessgnmi-server.timeoutis explicitly set.