Skip to content

Conversation

@DanG100
Copy link
Contributor

@DanG100 DanG100 commented Apr 26, 2023

These rules are working, will add to CI in future PR

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

Pull Request Test Coverage Report for Build 4811269088

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 66.613%

Totals Coverage Status
Change from base Build 4737015824: 0.1%
Covered Lines: 4124
Relevant Lines: 6191

💛 - Coveralls

@DanG100 DanG100 requested a review from wenovus April 26, 2023 18:32
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this affect repositories that import lemming?

@DanG100
Copy link
Contributor Author

DanG100 commented Apr 27, 2023

How does this affect repositories that import lemming?

We will make sure the lemming is usable with standard go tooling. I'll include some instructions in a follow up PR. But it's pretty simple, just need to keep go.mod and generate pb.go files up to date.

@DanG100 DanG100 merged commit a242eb6 into main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants