Skip to content

Conversation

@DanG100
Copy link
Contributor

@DanG100 DanG100 commented May 18, 2023

  • simplified port state proto
  • use forwarding notification instead of netlink for link state in interface reconciler
  • kernel and tap port implementation handle the state correctly

@DanG100 DanG100 requested a review from wenovus May 18, 2023 23:58
@github-actions
Copy link

github-actions bot commented May 19, 2023

Pull Request Test Coverage Report for Build 5026585253

  • 5 of 152 (3.29%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 2.346%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/internal/engine/engine.go 0 3 0.0%
dataplane/internal/kernel/kernel.go 0 3 0.0%
dataplane/forwarding/fwdport/ports/group.go 1 6 16.67%
dataplane/forwarding/fwdport/ports/kernel.go 0 9 0.0%
dataplane/handlers/interface.go 0 45 0.0%
dataplane/forwarding/fwdport/ports/tap.go 0 82 0.0%
Files with Coverage Reduction New Missed Lines %
dataplane/forwarding/fwdport/ports/kernel.go 1 7.92%
dataplane/forwarding/fwdport/ports/tap.go 1 1.81%
Totals Coverage Status
Change from base Build 5018244714: -0.001%
Covered Lines: 12382
Relevant Lines: 527858

💛 - Coveralls

@DanG100 DanG100 force-pushed the better-portstate branch from 17cd190 to 9fdefdf Compare May 19, 2023 17:05
@DanG100 DanG100 merged commit ba9bf8f into main May 19, 2023
@DanG100 DanG100 deleted the better-portstate branch May 19, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants