Refactor gobgp tasks's reconciler #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Declare commonly used paths. * Use updateAppliedState to allow concurrent threads to update the appliedState. * Add path subscriptions for BGP policies (not implemented yet) BGP integration tests pass
Pull Request Test Coverage Report for Build 5020512185
💛 - Coveralls |
wenovus
force-pushed
the
bgpconfig-refactor
branch
from
a4f7237 to
ed3efbf
Compare
DanG100
approved these changes
May 19, 2023
| } | ||
| } | ||
|
|
||
| func updateAppliedStateHelper[T ygot.GoStruct](yclient *ygnmi.Client, path ygnmi.SingletonQuery[T], appliedState T) { |
Contributor
There was a problem hiding this comment.
optional: inline this into updateAppliedState so that someone doesn't call it instead of updateAppliedState. it's only 3 lines
Contributor
Author
There was a problem hiding this comment.
I'm still just very slightly for keeping this since it might be applicable for other handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BGP integration tests pass