-
Notifications
You must be signed in to change notification settings - Fork 24
Support prefix-list BGP policies #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wenovus
commented
May 19, 2023
- Convert OC policies to GoBGP policies in configuration in the reconciler.
- Add BGP policy test spec. This is adapted from an existing one.
- Add prefix-list policy test.
* Convert OC policies to GoBGP policies in configuration in the reconciler. * Add BGP policy test spec. This is adapted from an existing one. * Add prefix-list policy test.
|
|
||
| syntax = "proto3"; | ||
|
|
||
| package policy_validation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is reason with a proto and not just a struct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there is another BGP policy testing framework that the user of this is looking at that currently uses this as the test interface. I'm simply using it here for uniformity and so I don't need to re-invent this. If there is no need for using a proto we can later change it, but it doesn't seem to have any harm.
Pull Request Test Coverage Report for Build 5050896170
💛 - Coveralls |
|
There are some strange non-deterministic errors appearing: Locally running With GitHub actions I've commented where bgp/tests/local_tests is failing due to a stale cache update -- I have no idea how that could happen since all gNMI operations for these tests happen sequentially, and tests are also run sequentially since they're in the same package: https://github.com/openconfig/lemming/actions/runs/5050247039/jobs/9060715556 Lastly there was a recursive cmp transformer failure that I also have no idea happened: https://github.com/openconfig/lemming/actions/runs/5050317179/jobs/9060884938 This is just a note for the future if these errors occur to help with debugging. |