Support AS Path Prepend #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanG100
reviewed
Aug 25, 2023
| "10.11.0.0/16", | ||
| "10.12.0.0/16", | ||
| "10.13.0.0/16", | ||
| "10.14.0.0/16", |
Contributor
There was a problem hiding this comment.
consider refactoring this test, it seems its testing too many things and it's not clear to me what's going on here
Contributor
Author
There was a problem hiding this comment.
I factored out the defined-sets into another helper function to minimize the logic in the switch statement which is I think the most confusing part, PTAL.
DanG100
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.