Skip to content

Conversation

@wenovus
Copy link
Contributor

@wenovus wenovus commented Aug 25, 2023

No description provided.

@wenovus wenovus requested a review from DanG100 August 25, 2023 20:13
@wenovus wenovus changed the base branch from as-path-prepend to main August 28, 2023 20:51
@wenovus wenovus changed the base branch from main to as-path-prepend August 28, 2023 20:52
Copy link
Contributor

@DanG100 DanG100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though same concern around complexity of the attributes test

Base automatically changed from as-path-prepend to main August 29, 2023 17:03
@wenovus
Copy link
Contributor Author

wenovus commented Aug 29, 2023

 policy_test.go:164: Replace(t) on ygnmi client (target: \"dut2\") at /network-instances/network-instance[name=DEFAULT]/protocols/protocol[identifier=BGP][name=BGP]/bgp/neighbors/neighbor[neighbor-address=127.0.0.2]/apply-policy/config/default-import-policy: Replace(t) at path origin:\"openconfig\"  elem:{name:\"network-instances\"}  elem:{name:\"network-instance\"  key:{key:\"name\"  value:\"DEFAULT\"}}  elem:{name:\"protocols\"}  elem:{name:\"protocol\"  key:{key:\"identifier\"  value:\"BGP\"}  key:{key:\"name\"  value:\"BGP\"}}  elem:{name:\"bgp\"}  elem:{name:\"neighbors\"}  elem:{name:\"neighbor\"  key:{key:\"neighbor-address\"  value:\"127.0.0.2\"}}  elem:{name:\"apply-policy\"}  elem:{name:\"config\"}  elem:{name:\"default-import-policy\"}: rpc error: code = Internal desc = update is stale, update is stale, update is stale: notification:",

@wenovus wenovus merged commit 2f32bbc into main Aug 29, 2023
@wenovus wenovus deleted the prefix-set-invert branch August 29, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants