Skip to content

Conversation

@robshakir
Copy link
Member

commit 2001e03fc68c61a478c1639efb851e3fa4b867f7
Author: Rob Shakir <robjs@google.com>
Date:   Sat Sep 2 00:36:02 2023 +0000

    Change signature of ribAddFn to support non-IPv4.
    
     * (M) gribi/gribi.go
      - Adopt an upstream change from gribigo to make the function
        called after an entry is found to be resolvable support more
        than just IPv4. This is required to support other address families
        in lemming.

 * (M) gribi/gribi.go
  - Adopt an upstream change from gribigo to make the function
    called after an entry is found to be resolvable support more
    than just IPv4. This is required to support other address families
    in lemming.
@robshakir
Copy link
Member Author

Upstream PR needs to be submitted before tests will pass.

@DanG100
Copy link
Contributor

DanG100 commented Sep 7, 2023

You could get this to build by go getting the sha of the commit in the gribigo branch with the change.

@robshakir
Copy link
Member Author

Thanks -- good idea.

It looks like there's an issue with the gobgp imports that are being used:

[18:26] robjs@aardvark:github.com/openconfig/lemming   gribigochg ✔                                                                                                                                                                                                                 12d ⚑  
▶ go mod tidy
go: downloading cloud.google.com/go/cloudbuild v1.13.0
go: downloading cloud.google.com/go/longrunning v0.5.1
go: finding module for package github.com/wenovus/gobgp/v3/pkg/table
go: finding module for package github.com/wenovus/gobgp/v3/pkg/bgpconfig
go: github.com/openconfig/lemming/bgp imports
	github.com/wenovus/gobgp/v3/pkg/bgpconfig: module github.com/wenovus/gobgp/v3@latest found (v3.0.0-20230816063421-5f01c74a5b06), but does not contain package github.com/wenovus/gobgp/v3/pkg/bgpconfig
go: github.com/openconfig/lemming/bgp imports
	github.com/wenovus/gobgp/v3/pkg/table: module github.com/wenovus/gobgp/v3@latest found (v3.0.0-20230816063421-5f01c74a5b06), but does not contain package github.com/wenovus/gobgp/v3/pkg/table

Should we be updating the wenovus/gobgp fork to use an updated module name to make this work as expected?

@DanG100
Copy link
Contributor

DanG100 commented Sep 14, 2023

worked for me, I pushed the changes to your branch

@robshakir
Copy link
Member Author

Ah, thanks! Not sure what went wrong there.

@robshakir robshakir merged commit 6f76539 into openconfig:main Sep 14, 2023
@robshakir robshakir deleted the gribigochg branch September 14, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants