Skip to content

Minor updates to generated code #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanG100 merged 2 commits into from
Sep 12, 2023
Merged

Minor updates to generated code #264

DanG100 merged 2 commits into from
Sep 12, 2023

Conversation

@DanG100
Copy link
Contributor

@DanG100 DanG100 commented Sep 12, 2023

  • Support for experimental types
  • Include an option describing the type in Create requests. This will be used in a follow up PR

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Pull Request Test Coverage Report for Build 6164857552

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 1.871%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/standalone/apigen/protogen/protogen.go 4 7 57.14%
Totals Coverage Status
Change from base Build 6152689364: 0.001%
Covered Lines: 11514
Relevant Lines: 615423
💛 - Coveralls

@DanG100 DanG100 merged commit 6697102 into main Sep 12, 2023
@DanG100 DanG100 deleted the annotate-types branch September 12, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexmasi alexmasi alexmasi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanG100 @alexmasi