Skip to content

Update GoBGP and remove soft reset tests #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wenovus merged 1 commit into from
Sep 20, 2023
Merged

Update GoBGP and remove soft reset tests #270

wenovus merged 1 commit into from
Sep 20, 2023

Conversation

@wenovus
Copy link
Contributor

@wenovus wenovus commented Sep 20, 2023

  • Update GoBGP to the preferred fork branch.
  • Remove "installPolicyAfterRoutes" tests that rely on soft reset. GoBGP (and likely other major vendor implementations) do not support automatic outbound soft resets, and testing policy does not need them (furthermore I don't currently see an OpenConfig way of triggering them manually). This reduces testing time and complexity.

@wenovus wenovus requested a review from DanG100 September 20, 2023 16:00
@wenovus wenovus merged commit 9a64024 into main Sep 20, 2023
@wenovus wenovus deleted the update-gobgp branch September 20, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wenovus @DanG100