Export NextHop in BGP attribute map #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The policy_tests.go file is updated to ignore that next-hop field when comparing attributes, so that previous test cases don't need to be rewritten. The test case does not yet modify the attribute itself, as this feature is not yet supported.
Devices like the OTG send the next-hop within MP_REACH_NLRI, while others (like gobgp itself) uses the NEXT_HOP. We must read both when converting back to OpenConfig. Note, that gobgp allows multiple next-hops to be represented in MP_REACH_NLRI (even though rfc-4760 only specifies a single next-hop). Since OpenConfig only represents single next-hops, we error if we see multiple next-hops. See https://datatracker.ietf.org/doc/html/rfc4760.
DanG100
approved these changes
Aug 7, 2024
IPv6 unicast allows adding multiple next-hop addresses in the MP_REACH_NLRI attribute. In that case, the second one is a link-local address. Since OC does not support multiple next-hops, we just export the first one. I added a comment explaining this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy_tests.go file is updated to ignore that next-hop field when comparing attributes, so that previous test cases don't need to be rewritten.
The test case does not yet modify the attribute itself, as this feature is not yet supported.