Skip to content

Conversation

@robshakir
Copy link
Member

commit ebfc91c7200f6e3a41e3c4a73eadd115520383e2
Author: Rob Shakir <robjs@google.com>
Date:   Mon Jan 6 20:34:01 2025 +0000

    Initialise the unimplemented server given that gRIBI is embedded.
    
     * (M) gribi/gribi.go
       - Ensure that the unimplemented server is initialised correctly.

This is required since gRPC added a check that the unimplemented servers
that are embedded as pointers must not be nil.

 * (M) gribi/gribi.go
   - Ensure that the unimplemented server is initialised correctly.
@robshakir robshakir requested a review from DanG100 January 6, 2025 21:09
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12640081523

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 2.76%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gribi/gribi.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
gnsi/pathz/pathz.go 2 84.03%
dataplane/standalone/pkthandler/pktiohandler/pktiohandler.go 8 44.74%
sysrib/zapi.go 9 71.5%
Totals Coverage Status
Change from base Build 12421778272: -0.002%
Covered Lines: 19961
Relevant Lines: 723122

💛 - Coveralls

@robshakir robshakir merged commit 0658390 into main Jan 6, 2025
10 checks passed
@robshakir robshakir deleted the gribi-embed branch January 6, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants