Initial fault interceptor implementation #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13530669446Details
💛 - Coveralls |
guoshiuan
approved these changes
Feb 25, 2025
tengyiG
pushed a commit
to tengyiG/lemming
that referenced
this pull request
Feb 26, 2025
bormanp
reviewed
Feb 26, 2025
bormanp
left a comment
bormanp
left a comment
There was a problem hiding this comment.
You are planning to remove the regex matching, right?
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package fault |
There was a problem hiding this comment.
Missing package comment.
Actually, it appears many things are missing godoc comments.
| var recv *faultMessage | ||
| select { // Receive the potential modified req from the fault RPC. | ||
| case recv = <-recvCh: | ||
| case <-time.After(time.Second): |
There was a problem hiding this comment.
this should be a constant or variable defined up top.
| } | ||
|
|
||
| i.receiversMu.Lock() | ||
| delete(i.receivers, msgID) |
There was a problem hiding this comment.
Shouldn't this be done even if we did not receive a message?
| } | ||
|
|
||
| func (i *Interceptor) sendRecvFault(ch chan *faultMessage, rpcID string, msg any, oErr error) (any, error) { | ||
| msgID := uuid.New().String() |
There was a problem hiding this comment.
There is no reason to create this prior to line 72.
| } | ||
|
|
||
| func (i *Interceptor) Unary(ctx context.Context, req any, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (any, error) { | ||
| rpcID := uuid.New().String() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.