Add fields to IR and IROptions used by settting the path origin from the YANG module name or a specified name. #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand option to set the path origin from the YANG module name or an arbitrarily specified name.
keogaki
changed the title
robshakir
requested changes
Apr 16, 2025
Member
robshakir
left a comment
robshakir
left a comment
There was a problem hiding this comment.
Thanks for the contribution -- but this doesn't look like the right design to me. We're adding things to the ygot-generated IR that are not really in-line with what the IR should be specifying -- i.e., pre-parsed details of YANG structures that code-generation can use.
robshakir
reviewed
Apr 16, 2025
robshakir
reviewed
May 23, 2025
Member
robshakir
left a comment
robshakir
left a comment
There was a problem hiding this comment.
Thanks for the changes. This looks better now that it is encapsulated in the IR generation. I have one suggested logic change, and then some style changes.
Member
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ygnmi PR154.