Skip to content
This repository was archived by the owner on Jul 18, 2023. It is now read-only.

Comments

Guidance for Artifact Authors#13

Merged
mikebrow merged 12 commits intoopencontainers:masterfrom
SteveLasker:spec
Apr 30, 2020
Merged

Guidance for Artifact Authors#13
mikebrow merged 12 commits intoopencontainers:masterfrom
SteveLasker:spec

Conversation

@SteveLasker
Copy link
Contributor

@SteveLasker SteveLasker commented Oct 3, 2019 •
edited by stevvooe
Loading

Artifacts Guidance:
This is the first of a few PRs that were tasked by the OCI TOB to serve 3 primary goals
This PR addresses how Artifact Authors utilize OCI manifest to push new artifact types to an OCI-distribution based registry.
Subsequent PRs will address

  • publishing well-known types, including registering with IANA and artifact publishing samples
  • what registry operators need, to support artifacts

This is ready for final review:

@SteveLasker
Artifacts Spec
d0a66bf 
Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
justincormack
justincormack reviewed Oct 4, 2019
View reviewed changes
@SteveLasker SteveLasker mentioned this pull request Oct 4, 2019
Closed
dmcgowan
dmcgowan reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
wking
wking reviewed Oct 11, 2019
View reviewed changes
matthew-russo
matthew-russo reviewed Oct 15, 2019
View reviewed changes
SteveLasker
SteveLasker commented Oct 15, 2019
View reviewed changes
Copy link
Contributor Author

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general comment:
Thank you all for the feedback. To manage quick response time iterating on ideas to incorporate, vs. focused spec time with PRs, I'll incorporate the feedback I thumbed up next week, as well as address some of the questions that should be incorporated into the spec.

mikebrow
mikebrow reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments regarding the first few sections..

@SteveLasker
Incorporate spec feedback
8218bd1 
Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
@SteveLasker
Incorporate spec feedback
9b08de0 
Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
lumjjb
lumjjb reviewed Oct 23, 2019
View reviewed changes
anweiss
anweiss reviewed Nov 21, 2019
View reviewed changes
@SteveLasker
Copy link
Contributor Author

SteveLasker commented Feb 10, 2020

A quick note. I've been following up with using Iana.org for the mediaType registration process. (https://www.iana.org/form/media-types) It looks very promising, with

  • vnd. for vendors
  • prs. tree: for personal
  • x. for unregistered, such as customer specific, or registry specific types.

I've registered vnd.oci.image to see how the process works. Once I have more info, I'll be able to complete that section and hopefully move to merging this spec as the basis.

Silvanoc
Silvanoc reviewed Feb 17, 2020
View reviewed changes
Silvanoc
Silvanoc reviewed Feb 17, 2020
View reviewed changes
@Silvanoc Silvanoc mentioned this pull request Feb 18, 2020
Closed
@lumjjb lumjjb mentioned this pull request Mar 5, 2020
Open
Spec feedback
a058b25 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
josephschorr
josephschorr reviewed Mar 25, 2020
View reviewed changes
PR feedback and formatting fixes
876538d 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
@SteveLasker SteveLasker force-pushed the spec branch 2 times, most recently from b0b2e85 to 876538d Compare April 7, 2020 19:03
PR feedback for layer processing
3ceb791 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
SteveLasker
SteveLasker commented Apr 7, 2020
View reviewed changes
Incorporate feedback-split out artifact publishing
136c68f 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
@SteveLasker
Copy link
Contributor Author

SteveLasker commented Apr 24, 2020 •
edited
Loading

Moving to the description to avoid being lost in detail.

mikebrow
mikebrow reviewed Apr 24, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments half way..

Incorporate feedback
2eea60d 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
mikebrow
mikebrow reviewed Apr 25, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments / questions. Mostly nits :-)

josephschorr
josephschorr reviewed Apr 27, 2020
View reviewed changes
Incorporate wording feedback
ebff776 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
mikebrow
mikebrow approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
good first pass

dmcgowan
dmcgowan suggested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content in this PR looks good but the conversion of this repository into a versioned spec should be broken out. I'm not convinced the Artifacts Specification section has actually defined a specification. The primary goals and everything after scope LGTM.

Incorporate versioning feedback
4c9b2c1 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
@SteveLasker SteveLasker requested a review from dmcgowan April 29, 2020 01:31
mikebrow
mikebrow reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments on the versioning/scope issue

Incorporate versioning and spec wording feedback
bad0ae6 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
dmcgowan
dmcgowan approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josephschorr
josephschorr reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly word smithing (which you're free to ignore). I also had one or two clarification points.

mikebrow
mikebrow approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow changed the title Artifacts Spec Guidance for Artifact Authors Apr 30, 2020
Incorporate syntax structure feedback
5bb554e 
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
mikebrow
mikebrow approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josephschorr
josephschorr approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmcgowan
dmcgowan approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stevvooe
stevvooe approved these changes Apr 30, 2020
View reviewed changes
Copy link

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit f86648a into opencontainers:master Apr 30, 2020
@SteveLasker SteveLasker mentioned this pull request May 11, 2020
Closed
jdolitsky added a commit to bloodorangeio/artifacts that referenced this pull request Feb 9, 2021
@jdolitsky
small readme update (opencontainers#13)
7d8f05c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

10 more reviewers

@wking wking wking left review comments

@justincormack justincormack justincormack left review comments

@anweiss anweiss anweiss left review comments

@lumjjb lumjjb lumjjb left review comments

@Silvanoc Silvanoc Silvanoc left review comments

@matthew-russo matthew-russo matthew-russo left review comments

@stevvooe stevvooe stevvooe approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@josephschorr josephschorr josephschorr approved these changes

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.