Skip to content
This repository was archived by the owner on Jul 18, 2023. It is now read-only.

Comments

Move implementers page to this repo#24

Merged
mikebrow merged 1 commit intoopencontainers:masterfrom
hasheddan:implementors
Feb 9, 2021
Merged

Move implementers page to this repo#24
mikebrow merged 1 commit intoopencontainers:masterfrom
hasheddan:implementors

Conversation

@hasheddan
Copy link
Contributor

@hasheddan hasheddan commented Jul 9, 2020

Adds page for projects or companies currently engaged in efforts to
support OCI artifacts.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and bring that file into the repo on this PR with a small edit.. s/Projects or companies currently supporting OCI Artifacts/Projects or companies currently engaged in efforts to support OCI Artifacts/

@hasheddan hasheddan changed the title Fix link to implementors Add implementers page Jul 9, 2020
@hasheddan
Copy link
Contributor Author

@mikebrow sounds good! Done ✔️

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie
Copy link
Member

Files like this get stale quick and there's no real way to validate this list.
Can we instead provide something that registries can put on their website/readme?

@hasheddan
Copy link
Contributor Author

@jzelinskie SGTM, I would recommend removing this link as was the original proposal, what do you think?

@mikebrow
Copy link
Member

I'm fine with duping this one to #4 or approving this edit for now and rebasing #4.

Files like this get stale quick and there's no real way to validate this list.

Intent is to have test cases for validation. As Steve wrote, these are but a couple wip projects being used for a proof of concept.

Can we instead provide something that registries can put on their website/readme?

We can also provide something that registries can put on their website (wip). This PR is just moving the current link from a private repo to this repo.

@josephschorr
Copy link
Contributor

@mikebrow Perhaps we get a test suite added to the OCI Compliance suite behind one of its testing options and just reference that and allow registries to (re)use the same OCI compliance badging?

@mikebrow
Copy link
Member

mikebrow commented Jul 14, 2020

@mikebrow Perhaps we get a test suite added to the OCI Compliance suite behind one of its testing options and just reference that and allow registries to (re)use the same OCI compliance badging?

absolutely.. just need to get along with that suite.. the dist. spec.. and this guidance repo..

In the mean time :-) .. we have a file that has a link to a remote repo. We should discuss the contents in #4 where steve holds the pen.. This pr is just fixing the link.. for the most part (IMO) not the contents of what it's linking to (#4).

Maybe retitle the PR to move the current implementors page to this repo.

@hasheddan hasheddan changed the title Add implementers page Move implementers page to this repo Jul 14, 2020
@hasheddan
Copy link
Contributor Author

@mikebrow done ✔️

@SteveLasker
Copy link
Contributor

@hasheddan, has Docker Hub completed the update to support expanded mediaTypes?
I realized this PR is referencing some stale content in the definitions-terms.md file. I'd like to merge and fix, but wanted to confirm Docker completed the work. Others were asking for an implementors PR as well.

@hasheddan
Copy link
Contributor Author

@SteveLasker it appears the work is still in progress (distribution/distribution#2934), though it does look pretty stale at this point. Not sure if this would fall into the category of still "engaging in efforts", but I presume it is still desired, especially with recent CNCF news.

/cc @jdolitsky

@jdolitsky
Copy link
Contributor

Docker Hub is not mentioned in this PR. Distribution (the opensource project) has supported the artifacts stuff since the very beginning, running with default settings.

@hasheddan
Copy link
Contributor Author

@jdolitsky thanks for the clarification. @SteveLasker I assumed you were talking about distribution since that is what is referenced in implementers.md here, but do we need to ensure that docker hub also supports?

@SteveLasker
Copy link
Contributor

woops, I read docker/distribution as docker hub. Too much multi-tasking.
@hasheddan, if you can just change to distribution/distribution, we can go ahead and merge.

@hasheddan
Copy link
Contributor Author

@SteveLasker done 👍

implementers.md Outdated
Projects or companies currently engaged in efforts to support OCI Artifacts

* [Azure Container Registry](https://aka.ms/acr/artifacts)
* [distribution/distribution](https://github.com/distribution/distribution/) - the reference implementation of the [OCI Distribution Spec][distribution-spec]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should drop "the reference implementation"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdolitsky done 👍

Adds page for projects or companies currently engaged in efforts to
support OCI artifacts.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@SteveLasker
Copy link
Contributor

SteveLasker commented Feb 9, 2021

LGTM

Approved with PullApprove

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit a282023 into opencontainers:master Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants