Skip to content
This repository was archived by the owner on Jul 18, 2023. It is now read-only.

Comments

Collection of definitions and terms#3

Merged
SteveLasker merged 1 commit intoopencontainers:masterfrom
SteveLasker:definitions-terms
Aug 29, 2019
Merged

Collection of definitions and terms#3
SteveLasker merged 1 commit intoopencontainers:masterfrom
SteveLasker:definitions-terms

Conversation

@SteveLasker
Copy link
Contributor

Signed-off-by: Steven Lasker stevenlasker@hotmail.com

@caniszczyk
Copy link
Collaborator

@SteveLasker I installed PullApprove so you need to ensure you get 2 LGTMs from folks moving forward to merge changes in :)

@SteveLasker
Copy link
Contributor Author

@SteveLasker I installed PullApprove so you need to ensure you get 2 LGTMs from folks moving forward to merge changes in :)

Yup, thanks for getting everything setup.

Copy link

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No problems here. I have a few inline nits.

Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

some nits but I can push an update later, is a start :)

@mikebrow
Copy link
Member

@caniszczyk The integration service -pull approve.. is pointing to the wrong group.. currently the image spec maintainers group. Can you please switch that over to artifacts group :-)

@caniszczyk
Copy link
Collaborator

@mikebrow should be fixed

@caniszczyk caniszczyk requested a review from mikebrow August 29, 2019 20:37
@caniszczyk
Copy link
Collaborator

caniszczyk commented Aug 29, 2019

LGTM

Approved with PullApprove

@SteveLasker SteveLasker merged commit 87b10c0 into opencontainers:master Aug 29, 2019
jdolitsky pushed a commit to bloodorangeio/artifacts that referenced this pull request Feb 9, 2021
* Add pull command

* Add push cmd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants