mini update 7: describe push workflow#167
Closed
pmengelbert wants to merge 15 commits intoopencontainers:reorgfrom
Closed
mini update 7: describe push workflow#167pmengelbert wants to merge 15 commits intoopencontainers:reorgfrom
pmengelbert wants to merge 15 commits intoopencontainers:reorgfrom
Conversation
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
f714b79 to
dafe1e1
Compare
Contributor
|
The various flavors of Push I would imagine are related to the various client constraints one may have. For example, when memory constrained, when network is flaky (so need frequent resuming), when there are no real constrains (so I can push in one shot), etc. Clients today for whatever reason have decided to implement only a single flavor. |
This is a new table of contents for the spec, designed to add simplicity and organization. Existing content will later be moved into one of these sections, or removed entirely if considered superfluous. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the overview section, including new introduction referring to "content" (vs. just container images). Move historical context section underneath overview. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the definitions section, introducing several terms and defintions which will serve as reference for the rest of the document. Also moved the "notational conventions" section into this section, removing any language that seemed unnecessary or related to compliance (which will be covered in the conformance section). Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements stating that all compliant registries must at least support Pull. Added a section regarding certification, linking to the opencontainers/oci-conformance repo. For the workflow sections, intentionally left blank, and will be added in a follow-up PR. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements stating that all compliant registries must at least support Pull. Added a section regarding certification, linking to the opencontainers/oci-conformance repo. For the workflow sections, intentionally left blank, and will be added in a follow-up PR. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
…-spec into mini-update-6 Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
…-spec into mini-update-6 Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
dafe1e1 to
8e13311
Compare
14 tasks
…-spec into mini-update-6 Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
8e13311 to
b347ee5
Compare
jdolitsky
requested changes
Jul 22, 2020
| <manifest byte stream> | ||
| ``` | ||
|
|
||
| `<name>` is the namespace of the repository, and the `<reference>` MUST be either a) a digest or b) a tag. |
Contributor
There was a problem hiding this comment.
nothing actionable in this PR, but tag should be added to definitions
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
b347ee5 to
d44db2d
Compare
jdolitsky
approved these changes
Aug 5, 2020
Contributor
|
Closing this in favor of #178 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on PR #166
The relevant diff can be found here:
https://github.com/bloodorangeio/distribution-spec/compare/mini-update-6...bloodorangeio:mini-update-7?expand=1
This is a larger section and will need review before finalization--thank you for your comments.