Skip to content

Add 307 as valid response for pulling blobs#398

Closed
sajayantony wants to merge 1 commit intoopencontainers:mainfrom
sajayantony:pull
Closed

Add 307 as valid response for pulling blobs#398
sajayantony wants to merge 1 commit intoopencontainers:mainfrom
sajayantony:pull

Conversation

@sajayantony
Copy link
Copy Markdown
Member

Fixes #397

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@jdolitsky
Copy link
Copy Markdown
Contributor

does this affect conformance tests at all, or are redirects simply followed? (i think they are)

@sudo-bmitch
Copy link
Copy Markdown
Contributor

Redirects are followed automatically in Go (https://pkg.go.dev/net/http#Client). Does this need to be more generic than just on a blob GET, i.e. a statement at the top indicating http redirect status codes should be supported by clients according to https://www.rfc-editor.org/rfc/rfc7231#section-6.4

@jdolitsky
Copy link
Copy Markdown
Contributor

Does this need to be more generic than just on a blob GET

That would seem to cover all bases here

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Apr 4, 2023

hmm.. adding redirects to the spec probably requires further consideration.

Was there any progress on creating a WG for auth?

@tianon
Copy link
Copy Markdown
Member

tianon commented Apr 6, 2023

Was there any progress on creating a WG for auth?

opencontainers/tob#119

@sajayantony
Copy link
Copy Markdown
Member Author

Closing this PR for now but will consider bringing up the issue during the call. Currently multiple clients already follow redirects but seems like this is intermingled with auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pulling a blob doesn't specify 307 as a valid response status code

5 participants