Skip to content

updating link to code of conduct in org repository#57

Merged
vbatts merged 1 commit into
opencontainers:masterfrom
vsoch:update/CoC-link
Feb 28, 2019
Merged

updating link to code of conduct in org repository#57
vbatts merged 1 commit into
opencontainers:masterfrom
vsoch:update/CoC-link

Conversation

@vsoch
Copy link
Copy Markdown
Contributor

@vsoch vsoch commented Feb 26, 2019

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

This is the 2/3 pull request to update the link to the code of conduct, moving from tob to the .github folder of org. This repo (unlike runtime-spec) has the link also in the contributing.md.

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 26, 2019

LGTM

Approved with PullApprove

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 26, 2019

LGTM

Approved with PullApprove

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments one nit and I think a broken link.

Comment thread CONTRIBUTING.md
[meeting.ics]: https://github.com/opencontainers/runtime-spec/blob/master/meeting.ics
[minutes]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/
[rfc5545]: https://tools.ietf.org/html/rfc5545
[security]: https://github.com/opencontainers/org/blob/master/security
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/s/security/security.md#reporting-security-issues/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just decided on the call to rename the code-of-conduct / change its location, so I think we should wait for opencontainers/.github#6 to be approved / merged and then I can update all links here.

Comment thread CONTRIBUTING.md
request on GitHub. Instead, disclose the issue responsibly by sending an email
to security@opencontainers.org (which is inhabited only by the maintainers of
the various OCI projects).
If you wish to report a security issue, please see the protocol under [security][security].
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit...
/s/see the protocol under [security]/follow the [OCI org security issue reporting procedure]/

Comment thread CONTRIBUTING.md Outdated
You can add the sign off when creating the git commit via `git commit -s`.

[code-of-conduct]: https://github.com/opencontainers/tob/blob/d2f9d68c1332870e40693fe077d311e0742bc73d/code-of-conduct.md
[code-of-conduct]: https://github.com/opencontainers/org/blob/master/.github/CODE_OF_CONDUCT.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now at the root https://github.com/opencontainers/org/blob/master/CODE_OF_CONDUCT.md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed, per our discussion in the OCI call!

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Feb 28, 2019

LGTM

Approved with PullApprove

1 similar comment
@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 28, 2019

LGTM

Approved with PullApprove

@vbatts vbatts merged commit c574672 into opencontainers:master Feb 28, 2019
@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Feb 28, 2019

https://sombrerohm.files.wordpress.com/2017/07/giphy.gif?w=556&h=556&crop=1

@vbatts vbatts mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants