Skip to content

Update spec language to support pushing multiple tags at once#600

Merged
sudo-bmitch merged 1 commit intoopencontainers:mainfrom
jcarter3:multiple-tag-push
Apr 22, 2026
Merged

Update spec language to support pushing multiple tags at once#600
sudo-bmitch merged 1 commit intoopencontainers:mainfrom
jcarter3:multiple-tag-push

Conversation

@jcarter3
Copy link
Copy Markdown
Contributor

Also can be used when pushing tags for a non-canonical algorithm (sha-512, blake3)

Implements #591

Comment thread spec.md Outdated
Comment thread spec.md Outdated
Comment thread spec.md Outdated
Comment thread spec.md Outdated
Comment thread spec.md Outdated
sudo-bmitch added a commit to sudo-bmitch/regclient that referenced this pull request Mar 19, 2026
Implementation of opencontainers/distribution-spec#600

Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch added a commit to sudo-bmitch/olareg that referenced this pull request Mar 19, 2026
Implementation of opencontainers/distribution-spec#600.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
Copy link
Copy Markdown
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there's a newer version of the RFC. So this updates that pointer and makes some, hopefully minor, tweaks.

Comment thread spec.md Outdated
Comment thread spec.md Outdated
Comment thread spec.md Outdated
Comment thread spec.md Outdated
andaaron added a commit to andaaron/zot that referenced this pull request Mar 21, 2026
andaaron added a commit to andaaron/zot that referenced this pull request Mar 21, 2026
andaaron added a commit to andaaron/zot that referenced this pull request Mar 21, 2026
andaaron added a commit to andaaron/zot that referenced this pull request Mar 22, 2026
@sudo-bmitch
Copy link
Copy Markdown
Contributor

I've added a test for this in the conformance redesign (disabled by default, but enabled with the dev version): #588

andaaron added a commit to andaaron/zot that referenced this pull request Mar 22, 2026
andaaron added a commit to andaaron/zot that referenced this pull request Mar 22, 2026
andaaron added a commit to andaaron/zot that referenced this pull request Mar 26, 2026
andaaron added a commit to andaaron/zot that referenced this pull request Mar 28, 2026
andaaron added a commit to andaaron/zot that referenced this pull request Mar 29, 2026
andaaron added a commit to project-zot/zot that referenced this pull request Mar 29, 2026
* feat: support pushing multiple tags for a single manifest

See opencontainers/distribution-spec#600

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

* fix: constants not replaced in swagger output

Also godot mandates comments ending in dots,
which produces bad results in the swagger generated files, see the extra ". which is now fixed below:

```
diff --git a/swagger/docs.go b/swagger/docs.go
index 84b0827..fb2c45c 100644
--- a/swagger/docs.go
+++ b/swagger/docs.go
@@ -114,7 +114,7 @@ const docTemplate = `{
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
@@ -200,7 +200,7 @@ const docTemplate = `{
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
diff --git a/swagger/swagger.json b/swagger/swagger.json
index cfeb390..247f95f 100644
--- a/swagger/swagger.json
+++ b/swagger/swagger.json
@@ -106,7 +106,7 @@
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
@@ -192,7 +192,7 @@
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
diff --git a/swagger/swagger.yaml b/swagger/swagger.yaml
index 57641c2..09b30dc 100644
--- a/swagger/swagger.yaml
+++ b/swagger/swagger.yaml
@@ -310,7 +310,7 @@ paths:
           schema:
             type: string
         "400":
-          description: bad request".
+          description: bad request
           schema:
             type: string
         "500":
@@ -366,7 +366,7 @@ paths:
           schema:
             type: string
         "400":
-          description: bad request".
+          description: bad request
           schema:
             type: string
         "500":
```

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

---------

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
@sudo-bmitch
Copy link
Copy Markdown
Contributor

sudo-bmitch commented Apr 3, 2026

LGTM, just needs the DCO and merge conflicts resolved. We could also squash the commits on the rebase. https://github.com/opencontainers/distribution-spec/pull/600/checks?check_run_id=69878174291

@jcarter3 jcarter3 force-pushed the multiple-tag-push branch 2 times, most recently from da0d61a to 7876da2 Compare April 4, 2026 21:29
sudo-bmitch
sudo-bmitch previously approved these changes Apr 5, 2026
Copy link
Copy Markdown
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used up my nit quota, so this LGTM.

dmcgowan
dmcgowan previously approved these changes Apr 6, 2026
@tianon tianon mentioned this pull request Apr 8, 2026
13 tasks
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry thought I had submitted the pr review, alas was stuck in pending

Comment thread spec.md
Comment thread spec.md
Comment thread spec.md
cainydev pushed a commit to cainydev/zot that referenced this pull request Apr 10, 2026
…t#3885)

* feat: support pushing multiple tags for a single manifest

See opencontainers/distribution-spec#600

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

* fix: constants not replaced in swagger output

Also godot mandates comments ending in dots,
which produces bad results in the swagger generated files, see the extra ". which is now fixed below:

```
diff --git a/swagger/docs.go b/swagger/docs.go
index 84b0827..fb2c45c 100644
--- a/swagger/docs.go
+++ b/swagger/docs.go
@@ -114,7 +114,7 @@ const docTemplate = `{
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
@@ -200,7 +200,7 @@ const docTemplate = `{
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
diff --git a/swagger/swagger.json b/swagger/swagger.json
index cfeb390..247f95f 100644
--- a/swagger/swagger.json
+++ b/swagger/swagger.json
@@ -106,7 +106,7 @@
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
@@ -192,7 +192,7 @@
                         }
                     },
                     "400": {
-                        "description": "bad request\".",
+                        "description": "bad request",
                         "schema": {
                             "type": "string"
                         }
diff --git a/swagger/swagger.yaml b/swagger/swagger.yaml
index 57641c2..09b30dc 100644
--- a/swagger/swagger.yaml
+++ b/swagger/swagger.yaml
@@ -310,7 +310,7 @@ paths:
           schema:
             type: string
         "400":
-          description: bad request".
+          description: bad request
           schema:
             type: string
         "500":
@@ -366,7 +366,7 @@ paths:
           schema:
             type: string
         "400":
-          description: bad request".
+          description: bad request
           schema:
             type: string
         "500":
```

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

---------

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
Signed-off-by: cainydev <wajo432@gmail.com>
@jcarter3 jcarter3 dismissed stale reviews from dmcgowan and sudo-bmitch via 62417fd April 21, 2026 16:55
@jcarter3 jcarter3 force-pushed the multiple-tag-push branch from 62417fd to 20d21cb Compare April 21, 2026 16:56
…tiple tags at once. Also can be used when pushing tags for a non-canonical algorithm (sha-512, blake3)

Co-authored-by: Brandon Mitchell <git@bmitch.net>
Signed-off-by: Jeff Carter <jeff.carter@docker.com>
@jcarter3 jcarter3 force-pushed the multiple-tag-push branch from 4d90975 to 1e06678 Compare April 21, 2026 16:57
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sudo-bmitch
Copy link
Copy Markdown
Contributor

I believe @dmcgowan is still a LGTM, and we've seen traction in the community on this (Docker Hub, Zot, olareg, and regclient). So I'll merge it and we can iterate later if anything comes up.

@sudo-bmitch sudo-bmitch merged commit ed885fa into opencontainers:main Apr 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants