updating CoC link and security link#42
Conversation
|
LGTM |
|
|
||
| Copyright © 2016 Docker, Inc. All rights reserved, except as follows. Code is released under the [Apache 2.0 license](LICENSE). This `README.md` file and the [`CONTRIBUTING.md`](CONTRIBUTING.md) file are licensed under the Creative Commons Attribution 4.0 International License under the terms and conditions set forth in the file [`LICENSE.docs`](LICENSE.docs). You may obtain a duplicate copy of the same license, titled CC BY-SA 4.0, at http://creativecommons.org/licenses/by-sa/4.0/. | ||
|
|
||
| [security]: https://github.com/opencontainers/org/blob/master/security |
There was a problem hiding this comment.
This looks like it needs a .md, the link 404s for me
There was a problem hiding this comment.
The security link above will be to a folder, so it should work without the .md.
There was a problem hiding this comment.
Is there a PR somewhere to drop the .md from the file?
| Copyright © 2016 Docker, Inc. All rights reserved, except as follows. Code is released under the [Apache 2.0 license](LICENSE). This `README.md` file and the [`CONTRIBUTING.md`](CONTRIBUTING.md) file are licensed under the Creative Commons Attribution 4.0 International License under the terms and conditions set forth in the file [`LICENSE.docs`](LICENSE.docs). You may obtain a duplicate copy of the same license, titled CC BY-SA 4.0, at http://creativecommons.org/licenses/by-sa/4.0/. | ||
|
|
||
| [security]: https://github.com/opencontainers/org/blob/master/security | ||
| [code-of-conduct]: https://github.com/opencontainers/org/blob/master/.github/CODE_OF_CONDUCT.md |
There was a problem hiding this comment.
This also 404s, maybe https://github.com/opencontainers/org/blob/master/code-of-conduct.md?
|
On 26/02/19 11:09 -0800, Derek McGowan wrote:
dmcgowan commented on this pull request.
>
# Copyright and license
Copyright © 2016 Docker, Inc. All rights reserved, except as follows. Code is released under the [Apache 2.0 license](LICENSE). This `README.md` file and the [`CONTRIBUTING.md`](CONTRIBUTING.md) file are licensed under the Creative Commons Attribution 4.0 International License under the terms and conditions set forth in the file [`LICENSE.docs`](LICENSE.docs). You may obtain a duplicate copy of the same license, titled CC BY-SA 4.0, at http://creativecommons.org/licenses/by-sa/4.0/.
+
+[security]: https://github.com/opencontainers/org/blob/master/security
Is there a PR somewhere to drop the `.md` from the file?
not yet. I'm not sure if she was _about_ to add that to the Contribution
PR
|
|
Sounds good, once that PR is open and matches then looks good here. We should probably merge this at the same time as that PR. |
|
here you go @dmcgowan opencontainers/.github#6 |
|
LGTM |
|
The commits have been squashed! |
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
|
Code of conduct link is updated to be outside of .github (and in all caps) to reflect discussion in OCI call. |
|
LGTM |
1 similar comment
|
LGTM |
|
|
|
lol |
|
I know, he's huge and terrifying. I think that makes it better? |
3 participants
Signed-off-by: Vanessa Sochat vsochat@stanford.edu
opencontainers/.github#3