specs-go/v1/*.go: align the deprecation style#1003
Merged
Conversation
vbatts
requested review from
cyphar,
jonboulle,
jonjohnsonjr,
sajayantony,
stevvooe and
sudo-bmitch
as code owners
vbatts
force-pushed
the
deprecation-notice
branch
from
2cb7200 to
7344074
Compare
Member
Author
|
hahaha, the proper deprecation causes CI to fail |
vbatts
force-pushed
the
deprecation-notice
branch
from
7344074 to
6d35fb2
Compare
Member
Author
|
fixed with per-line PTAL |
sajayantony
previously approved these changes
Feb 2, 2023
Use the golang styling for deprecation notices. This way importing from this source as a library may give notice. Co-authored-by: jonjohnsonjr <jonjohnson@google.com> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
force-pushed
the
deprecation-notice
branch
from
6d35fb2 to
b5998ba
Compare
Member
Author
|
we could consider a project wide All green. PTAL |
jonboulle
approved these changes
Feb 2, 2023
sajayantony
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the golang styling for deprecation notices. This way importing from this source as a library may give notice.
Signed-off-by: Vincent Batts vbatts@hashbangbash.com
this is a continuation/cleanup of #892 and #965