Skip to content

cmd/oci-image-tool: support multiple --ref#265

Merged
vbatts merged 1 commit into
opencontainers:masterfrom
runcom:multi-ref
Sep 6, 2016
Merged

cmd/oci-image-tool: support multiple --ref#265
vbatts merged 1 commit into
opencontainers:masterfrom
runcom:multi-ref

Conversation

@runcom
Copy link
Copy Markdown
Member

@runcom runcom commented Sep 6, 2016

Adds the possibility to validate multiple reference at once:

$ oci-image-tool validate --ref tag --ref 3.1 --ref 12.04 --ref latest --ref notlatest /home/amurdaca/src/github.com/docker/docker/test
reference "tag": OK
reference "3.1": OK
reference "12.04": OK
reference "latest": OK
reference "notlatest": OK
/home/amurdaca/src/github.com/docker/docker/test: OK

$ oci-image-tool validate --ref tag --ref 3.1 --ref 12.04 --ref notexists --ref latest --ref notlatest /home/amurdaca/src/github.com/docker/docker/test 
reference "tag": OK
reference "3.1": OK
reference "12.04": OK
/home/amurdaca/src/github.com/docker/docker/test: validation failed: refs/notexists: descriptor not found

/cc @RobDolinMS @s-urbaniak @philips @vbatts

Signed-off-by: Antonio Murdaca runcom@redhat.com

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@philips
Copy link
Copy Markdown
Contributor

philips commented Sep 6, 2016

LGTM

Approved with PullApprove

1 similar comment
@vbatts
Copy link
Copy Markdown
Member

vbatts commented Sep 6, 2016

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 4f6b5fd into opencontainers:master Sep 6, 2016
@runcom runcom deleted the multi-ref branch September 6, 2016 17:07
@s-urbaniak
Copy link
Copy Markdown
Collaborator

fwiw, lgtm too ;-)

wking added a commit to wking/image-spec that referenced this pull request Sep 7, 2016
Catch up with 6ca74be (cmd/oci-image-tool: support multiple --ref,
2016-09-06, opencontainers#265).

While I'm touching it, reformat this entry to one line per sentance
per the README's "Markdown style" section.

Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants