Skip to content

fixing code of conduct link#765

Merged
cyphar merged 1 commit into
opencontainers:masterfrom
vsoch:fix/CoC-link-again-again
Mar 5, 2019
Merged

fixing code of conduct link#765
cyphar merged 1 commit into
opencontainers:masterfrom
vsoch:fix/CoC-link-again-again

Conversation

@vsoch
Copy link
Copy Markdown
Contributor

@vsoch vsoch commented Feb 27, 2019

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Feb 27, 2019

Okay, signed commit, pulled changes from master, and now the correct link [code-of-conduct] instead of (code-of-conduct)``. This is strangely both humiliating and enlightening about best practices for pull requests!

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 27, 2019

😄
LGTM
The travis failure is something unrelated (though needs to be looked into separately)

Approved with PullApprove

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Feb 27, 2019

Poor TravisCI (and all his helpful humans) have had it rough recently. :/

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Feb 28, 2019

Code of conduct link moved outside of .github folder, as discussed in OCI call.

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 28, 2019

LGTM

Approved with PullApprove

@cyphar
Copy link
Copy Markdown
Member

cyphar commented Mar 5, 2019

LGTM.

Approved with PullApprove

@cyphar cyphar merged commit cea26c2 into opencontainers:master Mar 5, 2019
cyphar added a commit that referenced this pull request Mar 5, 2019
  fixing code of conduct link

LGTMs: @vbatts @cyphar
Closes #765
@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Mar 5, 2019

hooray! 🎊

@vsoch vsoch deleted the fix/CoC-link-again-again branch March 5, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants