Skip to content

github: bring forward the versions of golang tested/built with#879

Merged
vbatts merged 2 commits into
mainfrom
lint-fixes
Dec 2, 2021
Merged

github: bring forward the versions of golang tested/built with#879
vbatts merged 2 commits into
mainfrom
lint-fixes

Conversation

@vbatts
Copy link
Copy Markdown
Member

@vbatts vbatts commented Nov 24, 2021

the tool dep on github.com/mjibson/esc was failing on:

# golang.org/x/tools/internal/typeparams
../../../golang.org/x/tools/internal/typeparams/normalize.go:138:17: u.EmbeddedType undefined (type *types.Interface has no field or method EmbeddedType)

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Copy link
Copy Markdown
Contributor

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbatts vbatts merged commit b52c172 into main Dec 2, 2021
@vbatts vbatts deleted the lint-fixes branch December 2, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants