Fixing #1809#1810
Closed
frezbo wants to merge 1 commit into
Closed
Conversation
Author
|
Hmm seems we have a travis, wonder how we got this merged in? |
Member
Author
|
ahh yes, thanks. Closing in favor of #1808 |
Member
|
A simple way of fixing it would be to only allow PRs that have been rebased to be merged. I do this in |
Author
|
lol, I get that, but that's the standard I follow in our organisation. Always rebase before pushing. Maybe we should add that in contributing.md? What do you think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noel Georgi 18496730+frezbo@users.noreply.github.com
@AkihiroSuda @cyphar I think its time to add some simple PR checks, I can think of travis or something.