Skip to content

Make public ParseMountinfo#1970

Closed
BooleanCat wants to merge 1 commit intoopencontainers:masterfrom
BooleanCat:master
Closed

Make public ParseMountinfo#1970
BooleanCat wants to merge 1 commit intoopencontainers:masterfrom
BooleanCat:master

Conversation

@BooleanCat
Copy link
Copy Markdown

Whilst using libcontainer/mount.GetMounts() I had need of the underlying logic of parsing /proc/self/mountinfo for testing purposes. This PR makes that logic public, allowing for parsing of a Reader whose contents look like /proc/self/mountinfo.

Signed-off-by: Tom Godkin <thgodkin@gmail.com>
@BooleanCat
Copy link
Copy Markdown
Author

@crosbymichael @cyphar Looks like there's an issue with runc's billing information for the pullapprove service.

@crosbymichael
Copy link
Copy Markdown
Member

@caniszczyk for the pullapprove issues with billing

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Mar 4, 2020

LGTM

Approved with PullApprove

@kolyshkin
Copy link
Copy Markdown
Contributor

@BooleanCat you can use "github.com/docker/docker/pkg/mount".GetMounts() (see https://github.com/moby/moby/blob/master/pkg/mount/mount.go)

I'm against making this one public, we might change it in the future and would have to maintain backward compatibility

@AkihiroSuda
Copy link
Copy Markdown
Member

@kolyshkin Not huge fan of introducing dependency on moby/moby in this repo. Maybe the package should be split out to a separate repo?

@vrothberg
Copy link
Copy Markdown
Contributor

How about moving the package from Moby here? I believe that (nearly) all projects needing it already have runc a code dependency. It would also avoid a circular dependencies between Moby and runc (on a project level).

@AkihiroSuda
Copy link
Copy Markdown
Member

Closing per #2256 .
Moving moby/sys into opencontainers can be discussed in a separate issue.

@kolyshkin
Copy link
Copy Markdown
Contributor

@BooleanCat let me update my recommendation: please use mountinfo package from https://github.com/moby/sys; for example, see #2256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants