Skip to content

cgroup2: port over eBPF device controller from crun#2145

Merged
crosbymichael merged 1 commit into
opencontainers:masterfrom
AkihiroSuda:ebpf
Oct 31, 2019
Merged

cgroup2: port over eBPF device controller from crun#2145
crosbymichael merged 1 commit into
opencontainers:masterfrom
AkihiroSuda:ebpf

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Oct 17, 2019 •
edited
Loading

The implementation is based on https://github.com/containers/crun/blob/0.10.2/src/libcrun/ebpf.c

Although ebpf.c is originally licensed under LGPL-3.0-or-later, the author Giuseppe Scrivano agreed to relicense the file in Apache License 2.0: #2144 (comment)

See libcontainer/cgroups/ebpf/devicefilter/devicefilter_test.go for tested configurations.

Close #2144

@AkihiroSuda AkihiroSuda mentioned this pull request Oct 17, 2019
Closed
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Oct 17, 2019 •
edited
Loading

CI failing for ARM (EDIT: passing now)

CGO_ENABLED=1 GOARCH=arm GOARM=6 CC=arm-linux-gnueabi-gcc go build -buildmode=pie  -ldflags "-X main.gitCommit="bf9519326d3dcc4a78f3cddbc54ac7a78a0aa948" -X main.version=1.0.0-rc9+dev " -tags "seccomp apparmor selinux ambient" -o runc-armel .
# github.com/opencontainers/runc/vendor/github.com/cilium/ebpf
vendor/github.com/cilium/ebpf/syscalls.go:285:17: constant 3405662737 overflows int32
Makefile:125: recipe for target 'localcross' failed

@AkihiroSuda AkihiroSuda mentioned this pull request Oct 17, 2019
Closed
@AkihiroSuda AkihiroSuda force-pushed the ebpf branch 3 times, most recently from 970f501 to ce75263 Compare October 18, 2019 14:48
This was referenced Oct 25, 2019
Closed
Closed
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Oct 25, 2019

@giuseppe LGTY?

crosbymichael
crosbymichael reviewed Oct 28, 2019
View reviewed changes
Comment thread libcontainer/cgroups/fs/devices_v2.go Outdated
giuseppe
giuseppe approved these changes Oct 30, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Oct 30, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@AkihiroSuda
cgroup2: port over eBPF device controller from crun
faf673e 
The implementation is based on https://github.com/containers/crun/blob/0.10.2/src/libcrun/ebpf.c

Although ebpf.c is originally licensed under LGPL-3.0-or-later, the author
Giuseppe Scrivano agreed to relicense the file in Apache License 2.0:
opencontainers#2144 (comment)

See libcontainer/cgroups/ebpf/devicefilter/devicefilter_test.go for tested configurations.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Oct 31, 2019

rebased

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Oct 31, 2019

@dqminh @hqhq PTAL? This is the blocker for supporting cgroup2.

@mrunalp
Copy link
Copy Markdown
Contributor

mrunalp commented Oct 31, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Oct 31, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit b133fea into opencontainers:master Oct 31, 2019
@rektide rektide mentioned this pull request Dec 21, 2019
Closed
@dims dims mentioned this pull request Jan 28, 2020
Merged
@kolyshkin kolyshkin mentioned this pull request Nov 20, 2020
Open
@thaJeztah thaJeztah mentioned this pull request Apr 13, 2021
Merged
@pacoxu pacoxu mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosbymichael crosbymichael crosbymichael left review comments

+1 more reviewer

@giuseppe giuseppe giuseppe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cgroup2: eBPF device controller

4 participants

@AkihiroSuda @crosbymichael @mrunalp @giuseppe