cgroupv2: don't use GetCgroupMounts for criu c/r#2276
Merged
Conversation
Contributor
|
Makes sense. 👍 |
Contributor
Author
|
CI failure is unrelated and is fixed by #2268 |
Merged
When performing checkpoint or restore of cgroupv2 unified hierarchy, there is no need to call getCgroupMounts() / cgroups.GetCgroupMounts() as there's only a single mount in there. This eliminates the last internal (i.e. runc) use case of cgroups.GetCgroupMounts() for v2 unified. Unfortunately, there are external ones (e.g. moby/moby) so we can't yet let it return an error. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
rebased (to include #2268) to fix CI failure |
Member
|
LGTM |
kolyshkin
changed the title
Contributor
Author
|
Added WIP -- I overlooked another use of |
kolyshkin
changed the title
Contributor
Author
Nevermind, it was not in c/r code and can be dealt with separately. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing checkpoint or restore of cgroupv2 unified hierarchy,
there is no need to call getCgroupMounts() / cgroups.GetCgroupMounts()
as there's only a single mount in there.
This eliminates the last internal (i.e. runc) use of
cgroups.GetCgroupMounts()for v2 unified case. Unfortunately, thereare external ones (e.g. moby/moby) so we can't yet let it
return an error.
@adrianreber PTAL