Skip to content

CI cleanups#2320

Merged
AkihiroSuda merged 2 commits intoopencontainers:masterfrom
kolyshkin:vgr
Apr 20, 2020
Merged

CI cleanups#2320
AkihiroSuda merged 2 commits intoopencontainers:masterfrom
kolyshkin:vgr

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented Apr 17, 2020 •
edited
Loading

1. rm disablng weak deps in Vagrantfile

  1. it was not working previously because of a typo

  2. when a typo is removed, important packages such
    as container-selinux are not updated, so let's
    just remove this flag to avoid confusion.

Fixes: 84583eb (#2295)

2. rm BUILDTAGS from travis.yml

It is not needed since commit 89c108b.

@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Apr 17, 2020

Added some cleanup to travis.yml

@kolyshkin kolyshkin changed the title Vagrantfile: do disable weak deps CI cleanups Apr 18, 2020
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Apr 18, 2020

@mrunalp @crosbymichael @AkihiroSuda PTAL (easy to review)

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 18, 2020

CI failing

@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Apr 19, 2020

--> 7220508c48d
STEP 3: RUN dpkg --add-architecture armel && dpkg --add-architecture armhf && dpkg --add-architecture arm64 && dpkg --add-architecture ppc64el && apt-get update && apt-get install -y --no-install-recommends build-essential crossbuild-essential-arm64 crossbuild-essential-armel crossbuild-essential-armhf crossbuild-essential-ppc64el curl gawk iptables jq kmod libaio-dev libcap-dev libnet-dev libnl-3-dev libprotobuf-c-dev libprotobuf-dev libseccomp-dev libseccomp-dev:arm64 libseccomp-dev:armel libseccomp-dev:armhf libseccomp-dev:ppc64el libseccomp2 pkg-config protobuf-c-compiler protobuf-compiler python-minimal sudo uidmap && apt-get clean && rm -rf /var/cache/apt /var/lib/apt/lists/*;
error opening file /sys/fs/cgroup//system.slice/buildah-buildah055834495-18728.scope/cgroup.freeze: No such file or directory
kill container: No such process

Does not look related :-\

@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Apr 19, 2020

rebased on top of current master to kick CI

@kolyshkin kolyshkin marked this pull request as draft April 19, 2020 22:19
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Apr 19, 2020

Might be related, looking

@kolyshkin
Vagrantfile: rm disabling weak deps
5f0424c 
1. it was not working previously because of a typo

2. when a typo is removed, important packages such
   as container-selinux are not updated, so let's
   just remove this flag to avoid confusion.

Fixes: 84583eb
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
travis: rm BUILDTAGS
b6cc397 
It is not needed since commit 89c108b.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Apr 19, 2020 •
edited
Loading

Fixed (enabling weak deps was a bad bad idea)

@kolyshkin kolyshkin marked this pull request as ready for review April 19, 2020 23:28
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 20, 2020 •
edited
Loading

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Copy Markdown
Contributor

mrunalp commented Apr 20, 2020 •
edited by AkihiroSuda
Loading

LGTM

Approved with PullApprove

@AkihiroSuda AkihiroSuda merged commit 5b38ef7 into opencontainers:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin @AkihiroSuda @mrunalp