fix runc events error in cgroup v2#2352
Conversation
|
Thanks, please update https://github.com/opencontainers/runc/blob/master/tests/integration/events.bats as well |
lifubang
force-pushed
the
eventsv2
branch
6 times, most recently
from
b0eba0c to
760cf31
Compare
enable cgroup v2 tests in events.bats now. |
|
LGTM |
I have add a test now, but not easy, we should disable memory swap, or else it’s very hard to cause oom. |
| retry 10 1 eval "grep -q 'oom' events.log" | ||
| __runc delete -f test_busybox | ||
| ) & | ||
| wait # wait for the above sub shells to finish |
There was a problem hiding this comment.
Maybe add a small timeout in case runc won't ever exit?
timeout 10 wait
There was a problem hiding this comment.
Once #2370 merged, I'll update it together with some other changes.
There was a problem hiding this comment.
@kolyshkin timeout and wait can't be used together.
There was a problem hiding this comment.
Yes, you're right.
I am still concerned that this case might hang forever. Maybe we can run both __runc invocations with a timeout then. Something big, say 1 minute. Obviously, if OOM has not happened within a minute, the test has failed.
There was a problem hiding this comment.
Travis CI will return an error if there is no output after 150 seconds.
I met this error before I disable swap.
If you worry about this, I can write a simple C program to ensure causing oom kill.
There was a problem hiding this comment.
@kolyshkin use sh -c 'test=$(dd if=/dev/urandom ibs=5120k)' to ensure oom kill.
Because the memory limit is 4M.
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
It's getting much better and is almost ready. Just a few nits.
lifubang
force-pushed
the
eventsv2
branch
2 times, most recently
from
0789d76 to
284d9b2
Compare
Signed-off-by: lifubang <lifubang@acmcoder.com>
|
LGTM, thanks! |
|
LGTM |
How to test (from opencontainers/runc#2352 (comment)): (host)$ sudo swapoff -a (host)$ sudo ctr run -t --rm --memory-limit $((1024*1024*32)) docker.io/library/alpine:latest foo (container)$ sh -c 'VAR=$(seq 1 100000000)' An event `/tasks/oom {"container_id":"foo"}` will be displayed in `ctr events`. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
How to test (from opencontainers/runc#2352 (comment)): (host)$ sudo swapoff -a (host)$ sudo ctr run -t --rm --memory-limit $((1024*1024*32)) docker.io/library/alpine:latest foo (container)$ sh -c 'VAR=$(seq 1 100000000)' An event `/tasks/oom {"container_id":"foo"}` will be displayed in `ctr events`. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
How to test (from opencontainers/runc#2352 (comment)): (host)$ sudo swapoff -a (host)$ sudo ctr run -t --rm --memory-limit $((1024*1024*32)) docker.io/library/alpine:latest foo (container)$ sh -c 'VAR=$(seq 1 100000000)' An event `/tasks/oom {"container_id":"foo"}` will be displayed in `ctr events`. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
3 participants
fix #2351
Because there is no
oom notifierincgroup v2now.I think we should use
Inotifyto watchOOMinmemory.events.Signed-off-by: lifubang lifubang@acmcoder.com