libcontainer/stacktrace: fix inline func name#2355
Closed
zhsj wants to merge 1 commit intoopencontainers:masterfrom
Closed
libcontainer/stacktrace: fix inline func name#2355zhsj wants to merge 1 commit intoopencontainers:masterfrom
zhsj wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Contributor
Author
|
@opencontainers/runc-maintainers could you take a look? |
Member
|
@kolyshkin @AkihiroSuda ptal |
Member
|
@cyphar PTAL? |
The TestCaptureTestFunc fails on gccgo, because captureFunc is inlined there. Instead of using FuncForPC directly, using CallersFrames from runtime package, which is available since go1.7 This commit has an API break for the stacktrace package, which removes NewFrame func. But I think it's safe as the stacktrace is somehow an internal package of libcontainer. Signed-off-by: Shengjing Zhu <zhsj@debian.org>
Contributor
Author
|
ping? rebased to pick up the new ci. |
Contributor
Author
|
closing, as libcontainer/stacktrace is removed now. #3033 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TestCaptureTestFunc fails on gccgo, because captureFunc is inlined
there. Instead of using FuncForPC directly, using CallersFrames from
runtime package, which is available since go1.7
This commit has an API break for the stacktrace package, which removes
NewFrame func. But I think it's safe as the stacktrace is somehow an
internal package of libcontainer.
Signed-off-by: Shengjing Zhu zhsj@debian.org