cgroup refactoring#2387
Merged
Merged
Conversation
Contributor
|
Looks fine but needs rebase. |
Contributor
Author
|
Rebased |
Contributor
|
LGTM |
Contributor
Author
|
rebased again :) |
AkihiroSuda
reviewed
May 8, 2020
AkihiroSuda
reviewed
May 8, 2020
Member
|
Looks good but a couple of nits |
Instead of passing the whole map of paths, pass the path to the memory controller which these functions actually require. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
c.cgroupManager.GetPaths() are called twice here: once in currentState() and then in newSetnsProcess(). Reuse the result of the first call, which is stored into state.CgroupPaths. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
...and use it from libcontainer/factory_linux.go. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was generated entirely by gorename -- nothing to review here. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This patch was generated entirely by gorename -- nothing to review here. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1. Prevent theoretical "concurrent map access" error to m.paths. 2. There is no need to call m.Paths -- we can access m.paths directly. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Member
|
LGTM |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of patches aiming to prepare the codebase for #2386
Please review commits one by one.