cgroupv2: never write empty string to memory.swap.max#2410
Merged
Conversation
Because the empty string means set swap to 0. Signed-off-by: lifubang <lifubang@acmcoder.com>
Contributor
Contributor
|
@AkihiroSuda @mrunalp PTAL |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Never write empty string to memory.swap.max
Because the empty string means set swap to 0.
For example:
with memory limit:
The value of
memory.swap.maxis 4096.After we run
runc update --memory 33554432 test, the value ofmemory.swap.maxbecomes 0.This is a regression introduced by #2370 . I'm so sorry.
Signed-off-by: lifubang lifubang@acmcoder.com