Remove "-buildmode=pie" from platforms that don't support it#2419
Conversation
tianon
force-pushed
the
buildmode-arch-toggle
branch
from
db2a3ab to
f854b9e
Compare
This comment has been minimized.
This comment has been minimized.
tianon
force-pushed
the
buildmode-arch-toggle
branch
from
f854b9e to
c4b721a
Compare
tianon
force-pushed
the
buildmode-arch-toggle
branch
2 times, most recently
from
a6629b9 to
abeb84b
Compare
|
All good now, and all green at https://travis-ci.org/github/opencontainers/runc/builds/688947950 although something in the reporting of that status back to GitHub seems mixed up. 😅 |
Technically speaking, this is no longer true. LGTM otherwise |
|
That's fair, but it's still pretty close (definitely close enough to recognize readily, IMO) -- do you think the differences are large enough that I should remove that from the commit text? |
No, it totally makes sense to mention it, but I would replace "is taken directly from" by "is modelled after", "is inspired by", "idea is stolen from" or something... |
This sequence (and syntax) is inspired by containerd's implementation of the same: https://github.com/containerd/containerd/blob/4e08c2de67ec514b5602eea47804d41dfeabdc72/Makefile.linux#L21-L26 Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
tianon
force-pushed
the
buildmode-arch-toggle
branch
from
abeb84b to
be66519
Compare
|
Sure, totally fair -- updated!
|
|
LGTM |
|
LGTM |
4 participants
This sequence (and syntax) is taken directly from containerd's Makefile:
https://github.com/containerd/containerd/blob/4e08c2de67ec514b5602eea47804d41dfeabdc72/Makefile.linux#L21-L26